Remove github.com/jackc/pgx/v4 dependency#4379
Merged
kyleconroy merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
sqlc's own code no longer needs pgx/v4 at build time: - Delete internal/sqltest/pgx.go — the PostgreSQLPgx helper had no callers. - Migrate the sqlc-pg-gen internal tool from pgx/v4 to pgx/v5; the Connect/Query/Scan API surface used here is identical. pgx/v4 remains a supported code-generation target for sqlc users (SQLDriverPGXV4 constant and the imports emitted into generated code are unchanged); only sqlc's own dependency on the library is removed. go mod tidy also drops chunkreader/v2, pgconn, pgio, pgproto3/v2, pgtype, and golang.org/x/crypto as transitively unused. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
khepin
added a commit
to khepin/sqlc
that referenced
this pull request
Apr 18, 2026
…te-order-by-args * 'main' of https://github.com/sqlc-dev/sqlc: Map xid8 to pgtype.Uint64 for pgx/v5 (sqlc-dev#4387) Rename :one return variable when it conflicts with a parameter (sqlc-dev#4383) Coerce SQLite JSONB output regardless of type casing (sqlc-dev#4385) Dedupe sqlc.arg parameters wrapped in a type cast for MySQL (sqlc-dev#4384) Preserve MySQL optimizer hints in generated query text (sqlc-dev#4382) Skip CI/RTD builds when the change is irrelevant (sqlc-dev#4381) build(deps): bump the production-dependencies group across 1 directory with 11 updates (sqlc-dev#4380) build(deps): bump the production-dependencies group across 1 directory with 5 updates (sqlc-dev#4368) build(deps): bump pygments from 2.19.2 to 2.20.0 in /docs (sqlc-dev#4363) build(deps): bump requests from 2.32.5 to 2.33.0 in /docs (sqlc-dev#4357) Remove github.com/jackc/pgx/v4 dependency (sqlc-dev#4379) Upgrade Go toolchain to 1.26.2 (sqlc-dev#4378) build(deps): bump actions/upload-artifact from 6 to 7 (sqlc-dev#4320) docs: add sqlc-gen-sqlx to community language support (sqlc-dev#4371) build(deps): bump github.com/jackc/pgx/v5 from 5.8.0 to 5.9.0 (sqlc-dev#4377) Catch invalid ON CONFLICT DO UPDATE column references (sqlc-dev#4366)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sqlc-pg-geninternal tool frompgx/v4topgx/v5; theConnect/Query/ScanAPI surface used here is identicalinternal/sqltest/PostgreSQLPgxhelpergo mod tidydropspgx/v4plus the transitively-unusedchunkreader/v2,pgconn,pgio,pgproto3/v2,pgtype, andgolang.org/x/cryptopgx/v4 remains a supported code-generation target for sqlc users — the
SQLDriverPGXV4constant and the import string emitted into generated code are unchanged. Only sqlc's own build-time dependency on the library is removed.Test plan
go build ./...cleango test ./internal/sqltest/... ./internal/tools/... ./internal/codegen/...passes--tags=examplesCI run passessqlc-pg-genregenerates catalog files correctly against a live PostgreSQL🤖 Generated with Claude Code